fix(changelog): ensure user rendered files are trimmed to only a single ending newline#1118
Merged
codejedi365 merged 1 commit intopython-semantic-release:masterfrom Dec 9, 2024
Conversation
…le ending newline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
I came across this problem when doing some testing of the rebuild repo tests where the changelog would have a random extra newline. This resolves that.
How did you test?
The new rebuild tests will validate this when the tests actually work because the changelogs that are generated match the changelog build through the test code.