feat: add copy to clipboard button#84
Merged
neersighted merged 2 commits intopython-poetry:mainfrom Sep 8, 2022
branchv:copy-to-clipboard
Merged
feat: add copy to clipboard button#84neersighted merged 2 commits intopython-poetry:mainfrom branchv:copy-to-clipboard
copy to clipboard button#84neersighted merged 2 commits intopython-poetry:mainfrom
branchv:copy-to-clipboard
Conversation
|
Deploy preview for website ready! ✅ Preview Built with commit 1a336cc. |
Member
|
Those errors you mentioned were the issue that brought down the prod website back when I did the first iteration of this. I gave up back then, but I hope you can make it work. |
Member
Author
|
@Secrus I swapped out the rollup plugin and things look good to me now. Would be great if you could also verify |
Secrus
approved these changes
Sep 8, 2022
Member
|
LGTM, however, my previous attempt looked good as well 🤣. |
neersighted
approved these changes
Sep 8, 2022
Contributor
|
Can confirm that the clipboard copying is working on https://python-poetry.org/docs/. Great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt at #37. My only additions here are 1a336cc:
stimulus->@hotwired/stimulusrollup-plugin-svg-import->@rollup/plugin-imagesince the former was still throwing a parse errorCloses #77
EDIT: Just noticed rollup still silently throws a parse error on the svg although everything functions. Will come back to this later todayfixed