Merged
Conversation
2 tasks
branchv
approved these changes
Aug 4, 2022
Member
branchv
left a comment
There was a problem hiding this comment.
agreed, thanks a lot for updating this!
Side note: IMHO it would be nice to document a single command that allows pointing to a local folder
Absolutely, I'll add something to optionally symlink a local directory
|
Deploy preview for website ready! ✅ Preview Built with commit 0abb568. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was confused because I expected to find a sparse checkout under
content/docs, with the ability to interact withpoetryrepo with git commands.What actually happens is that a sparse checkout is made only temporary in a temporary folder, and the plain files are copied from the temporary folder to
content/docs.For the reader of the this doc it doesn't matter how the
.mdfiles are fetched from poetry repo. Using sparse checkout is just an internal choice of thebin/websitescript.Side note: IMHO it would be nice to document a single command that allows pointing to a local folder (typically
../poetry/docs) as an alternative to fetching from the public poetry repo. This would be handy in the use case where I have myself cloned poetry repo for local development, and am working on some doc changes among poetry code changes. If I can do something to make that happen, please let me know.