perf: only iter on found escape sequences#304
Merged
frostming merged 1 commit intopython-poetry:masterfrom Jul 27, 2023
Merged
Conversation
Finding used sequences is much faster than iterating over each one of them for each character. The iteration is still used, but at least it will only be used once per any sequence that is actually used in the string. Most strings won't include any sequences and will just be fast. @moduon MT-1075
frostming
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding used sequences is much faster than iterating over each one of them for each character.
The iteration is still used, but at least it will only be used once per any sequence that is actually used in the string.
Most strings won't include any sequences and will just be fast.
@moduon MT-1075