After initial fetch, save potentially-redirected url#9040
Closed
thatch wants to merge 1 commit intopython-poetry:mainfrom
Closed
After initial fetch, save potentially-redirected url#9040thatch wants to merge 1 commit intopython-poetry:mainfrom
thatch wants to merge 1 commit intopython-poetry:mainfrom
Conversation
dimbleby
reviewed
Feb 26, 2024
dimbleby
reviewed
Feb 26, 2024
abn
requested changes
Feb 26, 2024
Member
|
Regarding tests: The only meaningful test I can imagine is a network test like This takes 1-2 seconds. Not sure if we want that or rather do without a test. |
c515344 to
95c3981
Compare
95c3981 to
ba82891
Compare
Member
|
@thatch please run the following locally to get the failing pre-commit job passing. |
Member
We can modify the test at https://github.com/python-poetry/poetry/pull/9051/files#diff-d86ccfe236884d03286aee144a8a8dcb2016aa497261e05d81da2a7a1101ade6R406-R419 to account for this. def test_metadata_from_wheel_url_with_redirect_after_500(
assert_metadata_from_wheel_url: AssertMetadataFromWheelUrl,
) -> None:
assert_metadata_from_wheel_url(
negative_offset_error=(codes.internal_server_error, b"Internal server error"),
expected_requests=10,
redirect=True,
) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This is a draft -- no tests or relnotes. But appears to fix the issue in our environment.
Resolves: #9039