Remove references to --dev-only install option#5771
Merged
neersighted merged 1 commit intopython-poetry:masterfrom Jun 5, 2022
Merged
Remove references to --dev-only install option#5771neersighted merged 1 commit intopython-poetry:masterfrom
--dev-only install option#5771neersighted merged 1 commit intopython-poetry:masterfrom
Conversation
According to python-poetry#4864 (comment): > The `--dev-only` option was never available in a release, but was already > available in the master branch. Because it's a feature we will probably not > backport this to the 1.1 branch. Given that the option was only ever present when installing Poetry from master and was never available as part of a release, I think it's clearer to just remove all references to it rather than include a deprecation notice that would only be relevant to a tiny fraction of Poetry users.
neersighted
approved these changes
Jun 5, 2022
Contributor
Author
|
@neersighted Can you trigger a redeploy of the docs? It looks like the removed option is still present on the website. |
Member
|
The workflow will run tonight -- we haven't added a manual trigger, though you're welcome to PR a https://github.com/python-poetry/website/blob/main/.github/workflows/deploy-production.yml#L5 |
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to @finswimmer in #4864 (comment):
Given that the option was only ever present when installing Poetry from master and was never available as part of a release, I think it's clearer to just remove all references to it rather than include a deprecation notice that would only be relevant to a tiny fraction of Poetry users.
Pull Request Check List
Resolves: #4864
Added tests for changed code.