Skip to content

Added virtualenvs.prompt option to config#5606

Merged
neersighted merged 7 commits intopython-poetry:masterfrom
Secrus:virtualenv-prompt-opt
May 23, 2022
Merged

Added virtualenvs.prompt option to config#5606
neersighted merged 7 commits intopython-poetry:masterfrom
Secrus:virtualenv-prompt-opt

Conversation

@Secrus
Copy link
Copy Markdown
Member

@Secrus Secrus commented May 14, 2022

Pull Request Check List

Resolves: #3055

  • Added tests for changed code.
  • Updated documentation for changed code.

Since the previous PR on this issue (#3057) has gone stale with no changes since December 2020, I decided to take it upon myself and bring it to life. Some code was taken from the original PR, but as Poetry changed over this time, I had to make some changes of my own. I am not sure whether I did it right, in particularly:

  • typing of src/poetry/config/config.py:174 function (did my best to make mypy happy)
  • assert in test: tests/inspection/test_info.py:229. Don't really understand how that part works, especially what .call_count is.

dimbleby
dimbleby reviewed May 14, 2022
View reviewed changes
@abn abn added the area/docs Documentation issues/improvements label May 14, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 14, 2022 •
edited
Loading

Deploy preview for website ready!

✅ Preview
https://website-dugyjfy94-python-poetry.vercel.app

Built with commit 789c651.
This pull request is being automatically deployed with vercel-action

@Secrus Secrus requested a review from a team May 17, 2022 16:25
neersighted
neersighted requested changes May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a bit more touch-up to merge.

Also, do you know if this respects $VIRTUAL_ENV_DISABLE_PROMPT?

@Secrus
Copy link
Copy Markdown
Member Author

Secrus commented May 19, 2022 •
edited
Loading

Also, do you know if this respects $VIRTUAL_ENV_DISABLE_PROMPT?

@neersighted This is using built-in options from virtualenv, my changes just expose it to be used from poetry config, so as long as it isn't messed with by poetry shell, I would say it respects the env variable.

@Secrus Secrus force-pushed the virtualenv-prompt-opt branch from 24ab314 to 966aed0 Compare May 19, 2022 12:21
@Secrus Secrus requested a review from neersighted May 19, 2022 12:21
@Secrus Secrus requested a review from a team May 19, 2022 19:17
@neersighted neersighted merged commit 8a2eceb into python-poetry:master May 23, 2022
@neersighted neersighted mentioned this pull request May 23, 2022
Closed
2 tasks
@abn abn mentioned this pull request Jun 6, 2022
Merged
@mlegner mlegner mentioned this pull request Jun 7, 2022
Closed
3 tasks
@Secrus Secrus deleted the virtualenv-prompt-opt branch June 21, 2022 13:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 29, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@neersighted neersighted neersighted approved these changes

+1 more reviewer

@dimbleby dimbleby dimbleby left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/docs Documentation issues/improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pass --prompt to be project name

4 participants

@Secrus @dimbleby @neersighted @abn