Skip to content

Allow any file extension for README file#5357

Merged
Secrus merged 5 commits intopython-poetry:masterfrom
s-spindler:allow-any-readme
May 29, 2022
Merged

Allow any file extension for README file#5357
Secrus merged 5 commits intopython-poetry:masterfrom
s-spindler:allow-any-readme

Conversation

@s-spindler
Copy link
Copy Markdown
Contributor

@s-spindler s-spindler commented Mar 24, 2022 •
edited by branchv
Loading

Pull Request Check List

Resolves: #5356

  • Added tests for changed code.
  • Updated documentation for changed code.

@Secrus Secrus added the status/needs-consensus Consensus among maintainers required label May 17, 2022
neersighted
neersighted requested changes May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this -- looks like it just needs a little touchup and it's good.

@Secrus
Copy link
Copy Markdown
Member

Secrus commented May 24, 2022

I think it would be good to add a warning or note in pyproject docs, that formats different from md or rst might not be processed correctly on official PyPI.

@Secrus Secrus added the area/docs Documentation issues/improvements label May 24, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 24, 2022 •
edited
Loading

Deploy preview for website ready!

✅ Preview
https://website-lcwpovsyl-python-poetry.vercel.app

Built with commit 48bffbb.
This pull request is being automatically deployed with vercel-action

@s-spindler
Copy link
Copy Markdown
Contributor Author

s-spindler commented May 24, 2022

I added @neersighted's suggestion and added a sentence as suggested by @Secrus.

neersighted
neersighted previously approved these changes May 24, 2022
View reviewed changes
@Secrus
Copy link
Copy Markdown
Member

Secrus commented May 27, 2022

@s-spindler please fix the pre-commit problem so we could merge this.

@Secrus Secrus merged commit 3ee8584 into python-poetry:master May 29, 2022
@Secrus Secrus mentioned this pull request Jun 1, 2022
Merged
2 tasks
@abn abn mentioned this pull request Jun 6, 2022
Merged
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 29, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Secrus Secrus Secrus approved these changes

@neersighted neersighted neersighted left review comments

Assignees

No one assigned

Labels

area/docs Documentation issues/improvements status/needs-consensus Consensus among maintainers required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow other types of readme files

3 participants

@s-spindler @Secrus @neersighted