Skip to content

install package itself when combining --default with --only#4361

Closed
finswimmer wants to merge 1 commit intopython-poetry:masterfrom
finswimmer:install-package-default-only
Closed

install package itself when combining --default with --only#4361
finswimmer wants to merge 1 commit intopython-poetry:masterfrom
finswimmer:install-package-default-only

Conversation

@finswimmer
Copy link
Copy Markdown
Member

When combining the --default and --only flag on poetry install currently the project itself is not installed. This PR fixes this.

@finswimmer finswimmer marked this pull request as ready for review August 7, 2021 14:23
@finswimmer finswimmer requested a review from a team August 7, 2021 14:24
@abn
Copy link
Copy Markdown
Member

abn commented Oct 15, 2021

Is this the desired behaviour here? I am unclear on what the expected behaviour here is. Do we not expect the use of --only to implicitly enabled --no-root? And --default simply implies the activated dependencies are from the default group right? This is probably more a CLI API question.

Either way, we should add test cases here.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants