Skip to content

Raise ValueError when legacy_repository does not contain any valid package with required version#421

Merged
sdispater merged 1 commit intopython-poetry:masterfrom
pauleikis:master
Oct 15, 2018
Merged

Raise ValueError when legacy_repository does not contain any valid package with required version#421
sdispater merged 1 commit intopython-poetry:masterfrom
pauleikis:master

Conversation

@pauleikis
Copy link
Copy Markdown
Contributor

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This fixes #233 in the most straightforwad way, @sdispater please review, maybe there is a better way.

@Aulos
Copy link
Copy Markdown

Aulos commented Oct 10, 2018

I am having the same issue and this works for me

@sdispater sdispater merged commit 0b33b87 into python-poetry:master Oct 15, 2018
@sdispater
Copy link
Copy Markdown
Member

Looks good to me 👍

Thanks!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use private repository in poetry add

3 participants