Added memoryview support to frombytes()#6974
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Feb 25, 2023
Merged
Conversation
This was referenced Feb 25, 2023
Closed
hugovk
approved these changes
Feb 25, 2023
Contributor
|
I think this is missing a call to |
Closed
Merged
Member
Author
|
I've created PR #6976 to release the buffer. |
Member
Author
|
#6976 has now been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6933. Alternative to #6937
Adds support for using
memoryviewobjects infrombytes(), by changingPillow/src/decode.c
Line 124 in dbcd737
to use
y*instead. This is actually the "recommended way to accept binary data".See https://bugs.python.org/issue30625 for a discussion about why this change allows
memoryviewobjects to be accepted.