Always redirect pkg-config stderr to DEVNULL#6921
Closed
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Closed
Always redirect pkg-config stderr to DEVNULL#6921radarhere wants to merge 1 commit intopython-pillow:mainfrom
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Conversation
Member
|
Might the other errors be useful for people to debug failed installs? |
Member
Author
|
I created this after #6896 (review), where a user took the opposite view. I've created PR #7046 to go the other way instead, undoing the error handling change from that PR. |
Member
|
Closed in favour of #7046. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
_pkg_config, Pillow silently catches any Python exceptions that occur.If we're doing that, then it would seem consistent to also silence any errors that
pkg-configmight output.Just a note about the history of the
stderrhandling in this function - #6261 started this by silencing the libs call for one loop to prevent a specific error.