Consistently write in binary format in PPM tests by radarhere · Pull Request #6677 · python-pillow/Pillow

radarhere · 2022-10-23T04:11:50Z

test_file_ppm.py sometimes writes in binary format

Lines 196 to 197 in be8a28d

    
           with open(path, "wb") as f: 
        
               f.write(b"P3\n128 128\n255\n256")

and sometimes does not.

Lines 243 to 244 in be8a28d

    
           with open(path, "w", encoding="utf-8") as f: 
        
               f.write("P6")

This PR consistently writes in binary format in test_file_ppm.py.

radarhere added the Testing label Oct 23, 2022

radarhere mentioned this pull request Oct 23, 2022

pylint warnings #6659

Merged

Write in binary format

64e5baa

radarhere force-pushed the binary branch from c75bf78 to 64e5baa Compare October 23, 2022 04:18

radarhere changed the title ~~Write in binary format~~ Consistently write in binary format in PPM tests Oct 23, 2022

hugovk approved these changes Oct 23, 2022

View reviewed changes

hugovk added the automerge Automatically merge PRs that are ready label Oct 23, 2022

mergify bot merged commit eca2f5c into python-pillow:main Oct 23, 2022

radarhere deleted the binary branch October 23, 2022 20:53

Provide feedback

	with open(path, "wb") as f:
	f.write(b"P3\n128 128\n255\n256")