Fixed set_variation_by_name offset#6445
Merged
hugovk merged 2 commits intopython-pillow:mainfrom Oct 28, 2022
Merged
Conversation
3b9f7d7 to
0736c73
Compare
Contributor
|
Instead of increasing the epsilon so much, would it be better to modify You can grab the image rendered on the CI from the
|
0736c73 to
dea30e4
Compare
nulano
approved these changes
Jul 17, 2022
Member
Author
|
To be clear - I have implemented the suggestion from @nulano, and then he approved that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6439
When calling
FT_Set_Named_Instance, the index starts at 1.https://freetype.org/freetype2/docs/reference/ft2-multiple_masters.html#ft_set_named_instance
Apparently in #3802, I presumed it started at zero, leading to the wrong variation being selected.
Pillow/src/PIL/ImageFont.py
Line 798 in d53344b