Merged
Conversation
radarhere
commented
Feb 28, 2022
| return self._fixup_dict(info) | ||
|
|
||
| def _get_head(self): | ||
| version = b"\x2B" if self.bigtiff else b"\x2A" |
Member
Author
There was a problem hiding this comment.
\x2B is 43, and \x2A is 42, as per https://www.awaresystems.be/imaging/tiff/bigtiff.html
radarhere
commented
Feb 28, 2022
| (TiffTags.FLOAT, "f", "float"), | ||
| (TiffTags.DOUBLE, "d", "double"), | ||
| (TiffTags.IFD, "L", "long"), | ||
| (TiffTags.LONG8, "Q", "long8"), |
Member
Author
There was a problem hiding this comment.
https://www.awaresystems.be/imaging/tiff/bigtiff.html
The StripOffsets, StripByteCounts, TileOffsets, and TileByteCounts tags are allowed to have the datatype TIFF_LONG8 in BigTIFF.
hugovk
approved these changes
Mar 10, 2022
Member
hugovk
left a comment
There was a problem hiding this comment.
Thanks! Shall we add to release notes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4513
See https://www.awaresystems.be/imaging/tiff/bigtiff.html for a documentation reference.
The test image was created with
convert hopper.tif TIFF64:hopper_bigtiff.tif.