In show_file, use os.remove to remove temporary images #6010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This was referenced Feb 2, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
rminside asubprocessshell command, this PR switches to usingsubprocesswithout shell to open the image and thenos.remove. This should resolve any path problems.But there is a twist on macOS - Pillow sleeps before removing the image, and we presumably don't want to make our Python script hang for 20 seconds. Instead, this PR uses
subprocessto start a Python process that sleeps and removes the file afterwards.And since that makes
sleeping before removing the file nicer, this PR addssleepforxdg-open, instead of #5950, to help #5945 and #5968