Support 16-bit grayscale ImageQt conversion#5856
Merged
mergify[bot] merged 4 commits intopython-pillow:mainfrom Dec 14, 2021
Merged
Support 16-bit grayscale ImageQt conversion#5856mergify[bot] merged 4 commits intopython-pillow:mainfrom
mergify[bot] merged 4 commits intopython-pillow:mainfrom
Conversation
Member
|
When you say that you created 'a valid QImage', did the output visually match what it should? If I take demo code from https://www.pythonguis.com/faq/adding-images-to-pyqt5-applications/, modify it slightly and run with your PR, I just get black. import sys
from PIL import Image, ImageQt
from PyQt5.QtGui import QPixmap
from PyQt5.QtWidgets import QMainWindow, QApplication, QLabel
# hopper("I;16")
im = Image.open("Tests/images/hopper.ppm")
im = im.convert("I").convert("I;16")
class MainWindow(QMainWindow):
def __init__(self):
super(MainWindow, self).__init__()
label = QLabel(self)
pixmap = QPixmap(ImageQt.toqpixmap(im))
label.setPixmap(pixmap)
self.setCentralWidget(label)
self.resize(pixmap.width(), pixmap.height())
app = QApplication(sys.argv)
w = MainWindow()
w.show()
sys.exit(app.exec_())
|
Contributor
Author
|
@radarhere it's not exactly black, it's just really really dark. Presumably im = im.convert("I").convert("I;16").point(lambda i: i * 255)
|
Member
|
I'll move my example into tests. diff --git a/Tests/test_imageqt.py b/Tests/test_imageqt.py
index 08cab9976..48f9f370f 100644
--- a/Tests/test_imageqt.py
+++ b/Tests/test_imageqt.py
@@ -46,7 +46,27 @@ def test_image():
ImageQt.ImageQt(hopper(mode))
qt_format = ImageQt.QImage.Format if ImageQt.qt_version == "6" else ImageQt.QImage
if hasattr(qt_format, "Format_Grayscale16"): # Qt 5.13+
- ImageQt.ImageQt(hopper("I;16"))
+ im = ImageQt.ImageQt(hopper("I;16"))
+
+ import sys
+ from PyQt5.QtGui import QPixmap
+ from PyQt5.QtWidgets import QMainWindow, QApplication, QLabel
+
+ class MainWindow(QMainWindow):
+
+ def __init__(self):
+ super(MainWindow, self).__init__()
+
+ label = QLabel(self)
+ pixmap = QPixmap.fromImage(im)
+ label.setPixmap(pixmap)
+ self.setCentralWidget(label)
+ self.resize(pixmap.width(), pixmap.height())
+
+ app = QApplication(sys.argv)
+ w = MainWindow()
+ w.show()
+ app.exec_()
def test_closed_file():The above code still shows the black, or 'really really dark' image. I'm just saying that while this PR may not generate any errors, it is also not producing correct images. That's likely not a problem you've caused - Pillow does not have very good handling of I;16 in general. |
Member
|
I've created cmbruns#1 to fix the 'really really dark' image. |
e129fab to
037354e
Compare
037354e to
768c189
Compare
radarhere
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Expected behavior: A valid QImage is created.
Behavior without this code change:
ValueError: unsupported image mode 'I;16'I verified that a valid QImage is created with this change. Sorry I cannot share the test image I am using.