Do not use background or transparency index for new color#5564
Merged
radarhere merged 2 commits intopython-pillow:masterfrom Jun 30, 2021
Merged
Do not use background or transparency index for new color#5564radarhere merged 2 commits intopython-pillow:masterfrom
radarhere merged 2 commits intopython-pillow:masterfrom
Conversation
hugovk
reviewed
Jun 30, 2021
hugovk
approved these changes
Jun 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4202
When the code from that issue calls
getcolor()to find a new color to draw with, it picks 255. However, the image from that issue has aninfo["transparency"]of 255. So Pillow draws with the transparency index, which produces unexpected results.This PR skips the background and transparency index when calling
getcolor()to prevent this.