Skip to content

Added --remove-dist-egg option #4990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
radarhere wants to merge 2 commits into from
Closed

Added --remove-dist-egg option #4990

radarhere wants to merge 2 commits into from

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Oct 18, 2020

Resolves #4981

Adds a --remove-dist-egg flag to setup.py. It removes any created dist/*.egg file. This is also added to make release-test.

@radarhere radarhere mentioned this pull request Oct 18, 2020
Closed
@hugovk
Copy link
Member

hugovk commented Oct 18, 2020

To try and keep the monster setup.py a bit leaner, do you think rm dist/*.egg in make release-test would be enough?

Prefixing like -rm dist/*.egg tells make to ignore any errors (e.g. file not found): https://stackoverflow.com/a/2670143/724176

@radarhere radarhere mentioned this pull request Oct 19, 2020
Merged
@radarhere
Copy link
Member Author

radarhere commented Oct 19, 2020

My thinking was to avoid removing any other eggs that might also be in the 'dist' directory - but I realise that's not really a situation that's likely to occur.

Ok, see #4992

@radarhere radarhere closed this Oct 19, 2020
@radarhere radarhere deleted the egg branch October 19, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Release process creates a dist/*.egg file

2 participants

@radarhere @hugovk