Raise the same error if a truncated image is loaded a second time#3965
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Sep 20, 2019
Merged
Raise the same error if a truncated image is loaded a second time#3965hugovk merged 1 commit intopython-pillow:masterfrom
hugovk merged 1 commit intopython-pillow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3863, and see also #2977, two issues that find it strange that Pillow is inconsistent between the first
load()of a truncated image, and the second.After
load()is called on a truncated image, an error is raised and there is a line -self.tile = []. This means that whenload()is called a second time, it thinks there is nothing to do and does not return the same truncated error. This logic has been present since the fork.Instead, this PR removes that line, causing the same error to be raised on subsequent loads. It also resets an internal variable of PngImagePlugin, to fix an error that was raised when changing the tests for this, also providing consistency by resetting the image to it's initial state.