Added EXIF support for PNG #3674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Mar 11, 2019
Member
hugovk
left a comment
There was a problem hiding this comment.
Please can you also add release notes?
Member
Author
|
Okay, done. Also, in docs/handbook/image-file-formats.rst I've added a version string and adjusted the wording of my new paragraph. |
Member
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3644
The new image for the test suite is taken from #3557. PNG's
_openmethod only reads up until the first IDAT chunk. In that image, the eXIf chunk appears after that, meaning that the EXIF data will not be read until theloadmethod is called.Rather than loading the whole image in
_open, I suggest that_getexifloads the image if the EXIF chunk is not yet present. The downside of this is thatim.info["exif"]is unreliable if the image has not been loaded, but as this is a new feature, that unreliability is not a step backwards at least.