Merged
Conversation
Member
Author
|
Coverage dropped because AppVeyor didn't run: https://ci.appveyor.com/project/Python-pillow/pillow/history (It passed on my fork: https://ci.appveyor.com/project/hugovk/pillow/builds/21993434) Closing and re-opening in case it triggers it. |
Member
Author
|
✅ That sorted it. |
Member
Author
|
Merging to unblock CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a new release of Flake8 (3.7.1), including a new release of pyflakes (2.1.0), which brings in some new tests which fail:
https://travis-ci.org/python-pillow/Pillow/jobs/486309539#L224
Simple comment indentation.
It now checks mypy type comments. This one isn't a real mypy type comment, so change
type:toType:.The
Unionone can be fixed withfrom typing import Union, but that introduces a dependency on the mypytypingmodule. We have issue #2625 to add typing support, so I've removed it from here.