Pypy buffer interface workaround #2294
Merged
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes/Replaces/Fixes #2289
Pypy in versions 5.4.1 and 5.6 fail prepatch, but 5.3.1 is successful (on both precise and trusty, it's a pypy thing, not a ubuntu version thing, even though it's coming up because we're looking at updating the testing distro).
Specifically, in _imaging.c, this line:
Returns a failure when passed a string buffer, e.g.
In this particular case, if the buffer fails, the item is then interpreted as a tuple, and that fails. There are other calls where this fails directly back to python, such as
test_file_icns.py:test_jp2_iconChanges proposed in this pull request: