Also switch TIFFImagePlugin to logging#1589
Closed
anntzer wants to merge 1 commit intopython-pillow:masterfrom
Closed
Also switch TIFFImagePlugin to logging#1589anntzer wants to merge 1 commit intopython-pillow:masterfrom
anntzer wants to merge 1 commit intopython-pillow:masterfrom
Conversation
Just some mechanical changes. The remaining file using print is OLEFile, which has its own logic, but I noticed that @decalage's bitbucket repo has now switched to using logging as well.
Member
|
Please don't. Most of the debugging in these is setup for debugging at dev time, not runtime debugging of images that are bad. When something happens with an image, they get dumped into the django logs and they confuse people. That's been a problem with switching the other devugging to logs, but I think it would wind up being worse for this because most of them are a far lower level of information. |
Contributor
Author
|
I don't know what the exact problem is but I'd guess this is just due to people adding a logger at the debug level to the root handler (hey, they're asking for debug info from all librairies...). On the other hand I don't really care either. Feel free to revert #1205 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some mechanical changes. The remaining file using print is OLEFile,
which has its own logic, but I noticed that @decalage's bitbucket repo has now
switched to using logging as well.