Flaky test: Tests/test_file_eps.py::test_timeout #6877
Description
test_timeout[Tests/images/timeout-d675703545fee17acab56e5fec644c19979175de.eps] in test_file_eps.py is a flaky test that intermittently fails. It often passes when restarted.
It often fails on the ubuntu-22.04-jammy-ppc64le and ubuntu-22.04-jammy-s390x Docker images jobs, which are pretty slow anyway - they take between 15-25 mins, so restarting can mean a long additional wait.
It would be good to fix this: fix/rewrite the test, or the code if the problem is there, or maybe even remove it. There are also pytest plugins to re-run flaky tests a number of times.
Perhaps this test should be skipped for these particular flavours.
The failure
=================================== FAILURES ===================================
_ test_timeout[Tests/images/timeout-d675703545fee17acab56e5fec644c19979175de.eps] _
test_file = 'Tests/images/timeout-d675703545fee17acab56e5fec644c19979175de.eps'
@pytest.mark.timeout(timeout=5)
@pytest.mark.parametrize(
"test_file",
["Tests/images/timeout-d675703545fee17acab56e5fec644c19979175de.eps"],
)
def test_timeout(test_file):
with open(test_file, "rb") as f:
with pytest.raises(Image.UnidentifiedImageError):
> with Image.open(f):
Tests/test_file_eps.py:294:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/vpy3/lib/python3.10/site-packages/PIL/Image.py:3268: in open
im = _open_core(fp, filename, prefix, formats)
/vpy3/lib/python3.10/site-packages/PIL/Image.py:3254: in _open_core
im = factory(fp, filename)
/vpy3/lib/python3.10/site-packages/PIL/ImageFile.py:117: in __init__
self._open()
/vpy3/lib/python3.10/site-packages/PIL/EpsImagePlugin.py:227: in _open
s_raw = fp.readline()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <PIL.EpsImagePlugin.PSFile object at 0x40086451e0>
def readline(self):
s = [self.char or b""]
self.char = None
c = self.fp.read(1)
> while (c not in b"\r\n") and len(c):
E Failed: Timeout >5.0s
/vpy3/lib/python3.10/site-packages/PIL/EpsImagePlugin.py:180: FailedThe logs
-
ubuntu-22.04-jammy-ppc64le
https://github.com/python-pillow/Pillow/actions/runs/3819225905/jobs/6496611918#logs
Full logs: logs_29831.zip -
ubuntu-22.04-jammy-s390x
https://github.com/python-pillow/Pillow/actions/runs/3876084655/jobs/6609487015
Full logs: logs_30163.zip
The test
Lines 286 to 295 in 50f7888