Allow subclassing DateTimes to work as expected#707
Closed
gazpachoking wants to merge 4 commits intopython-pendulum:masterfrom
Closed
Allow subclassing DateTimes to work as expected#707gazpachoking wants to merge 4 commits intopython-pendulum:masterfrom
gazpachoking wants to merge 4 commits intopython-pendulum:masterfrom
Conversation
a732f11 to
0c94f35
Compare
5 tasks
Contributor
Author
|
Any way to get some eyes on this? I'd love to get this working. |
2 tasks
Collaborator
|
Thanks for this PR. This looks good however I integrated this change in #732 which includes improvements to |
Contributor
Author
|
Adding the instance method to the class was my preferred method as well, but I didn't want to change the API without blessing. Even more useful that it's public, thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if subclassing DateTime, there are many methods which would return a plain DateTime type, rather than the subclassed type.
I made a new
DateTime._instanceclassmethod so as not to change the public interface, which is used bypendulum.instanceas well as internally in the DateTime class.Fixes #203
Pull Request Check List
These changes don't affect using the library directly, only when subclassed externally. Existing tests should ensure internal behavior hasn't changed.