Move warnings to user context#899
Move warnings to user context#899Julian merged 1 commit intopython-jsonschema:mainfrom Kojoley:move-warning-to-user-context
Conversation
|
Thanks, this is definitely reasonable -- can you update the tests for these deprecations? Appreciated. |
Codecov Report
@@ Coverage Diff @@
## main #899 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 20 20
Lines 3181 3188 +7
Branches 430 430
=======================================
+ Hits 3126 3133 +7
Misses 44 44
Partials 11 11
Continue to review full report at Codecov.
|
I could not figure out what should I update, the test suit seems to be fine as-is, may you please explain what do you mean? |
|
Each deprecation here has a test asserting that some code triggers the deprecation warning. |
Currently the warning location points inside the jsonschema code and it takes an additional effort to find where the actual code that triggers it is located.
|
Should be done now. |
|
Wonderful, thanks! |
Currently the warning location points inside the
jsonschemacode and it takes an additional effort to find where the actual code that triggers it is located.