Ensure all elements of arrays are verified for uniqueness#875
Merged
Julian merged 2 commits intopython-jsonschema:mainfrom Nov 4, 2021
Merged
Conversation
This reverts commit ed4693c.
Fix bug where the function would return (True) early if the first two items of the array are unique, preventing verification of other array items.
Codecov Report
@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 19 19
Lines 3120 3121 +1
Branches 377 378 +1
=======================================
+ Hits 3068 3069 +1
Misses 41 41
Partials 11 11
Continue to review full report at Codecov.
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #866
Changes proposed in this PR:
_utils.uniq()function where the function would return (True) early if the first two items of the array are unique, preventing verification of other array items.