Update cron workflow name#473
Merged
sirosen merged 1 commit intopython-jsonschema:mainfrom Aug 5, 2024
Merged
Conversation
Member
|
Thanks for this; good catch! Let's leave it with "weekly" for now. The idea I had when I named the prior one "daily" was that it would be the workflow for potentially multiple daily jobs. So, following that reasoning, this is a workflow for any weekly jobs. (I'm not super attached to this scheme, but I'd rather not change it unless there's a clear reason to do so.) I'll look at that build failure after merging this. I'm guessing that py3.8 support is uneven across upstream libraries, and it leads to some weird situation. |
Contributor
Author
|
Awesome, see my link in my accidental PR #474 re the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like 845f8e5 changed
cron.yamlto run weekly instead of daily, but thenameof the workflow was left asdaily. This just updates thename.(Or perhaps the
nameshould be something likescheduled-schema-update?)