Skip to content

Update vendored schemas#409

Merged
sirosen merged 1 commit intopython-jsonschema:mainfrom
hugovk:update-github-workflows.json
Mar 31, 2024
Merged

Update vendored schemas#409
sirosen merged 1 commit intopython-jsonschema:mainfrom
hugovk:update-github-workflows.json

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented Mar 28, 2024

Updated by running ./scripts/vendor-schemas.py, motivation is to support merge queues in GitHub Actions workflows:

-on: [push, pull_request, workflow_dispatch]
+on: [push, pull_request, workflow_dispatch, merge_group]

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

Validate GitHub Workflows................................................Failed
- hook id: check-github-workflows
- exit code: 1

ok -- validation done
Schema validation errors were encountered.
  .github/workflows/test.yml::$.on: ['push', 'pull_request', 'workflow_dispatch', 'merge_group'] is not valid under any of the given schemas
  Underlying errors caused this.

  Best Match:
    $.on: ['push', 'pull_request', 'workflow_dispatch', 'merge_group'] is not of type 'string'
  Best Deep Match:
    $.on[3]: 'merge_group' is not one of ['branch_protection_rule', 'check_run', 'check_suite', 'create', 'delete', 'deployment', 'deployment_status', 'discussion', 'discussion_comment', 'fork', 'gollum', 'issue_comment', 'issues', 'label', 'member', 'milestone', 'page_build', 'project', 'project_card', 'project_column', 'public', 'pull_request', 'pull_request_review', 'pull_request_review_comment', 'pull_request_target', 'push', 'registry_package', 'release', 'status', 'watch', 'workflow_call', 'workflow_dispatch', 'workflow_run', 'repository_dispatch']

  2 other errors were produced. Use '--verbose' to see all errors.

@sirosen
Copy link
Copy Markdown
Member

sirosen commented Mar 31, 2024

Thanks for giving me a nudge on this, and taking the initiative to run the update!
I try to stay on top of releases to ship out new schemas regularly, but my schedule has been a bit bananas and I haven't done one in -- checks release history -- quite a while.

I'll get this shipped out and you should be able to start using the new schema right away.
Please always feel free to drop by and request an update if there's something you need!

@sirosen sirosen merged commit c696751 into python-jsonschema:main Mar 31, 2024
@hugovk hugovk deleted the update-github-workflows.json branch April 1, 2024 06:38
@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented Apr 1, 2024

Thank you!

It probably wouldn't be too hard to set up a cron to run the handy update script and create a PR once a month or so.

@edgarrmondragon
Copy link
Copy Markdown
Contributor

Thank you!

It probably wouldn't be too hard to set up a cron to run the handy update script and create a PR once a month or so.

Like #398? 😅

@sirosen
Copy link
Copy Markdown
Member

sirosen commented Apr 1, 2024

Yeah, I did the hard part to get it wired up and then it has become noise for me because it's going off constantly and I learned to tune it out! 😅

I need to crank it back from daily to weekly. In terms of the eternal problems I, like many people, have managing workload and attention, that will provide a better signal that I really ought to stop by and do a release.

@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented Apr 2, 2024

Please see PR #412 to switch to weekly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants