Skip to content

Add vendoring of cloudbuild schema#339

Merged
sirosen merged 3 commits intopython-jsonschema:mainfrom
nikolaik:nikolaik/vendor-cloudbuild
Nov 24, 2023
Merged

Add vendoring of cloudbuild schema#339
sirosen merged 3 commits intopython-jsonschema:mainfrom
nikolaik:nikolaik/vendor-cloudbuild

Conversation

@nikolaik
Copy link
Copy Markdown
Contributor

TODO: waiting for schemastore.org to be back up to run and add tests

@sirosen sirosen force-pushed the nikolaik/vendor-cloudbuild branch from 33681d6 to 6524183 Compare November 24, 2023 21:34
@sirosen
Copy link
Copy Markdown
Member

sirosen commented Nov 24, 2023

I've just picked this up with a force-push to rebase and run the jobs to grab the latest schema. I'd like to add at least one positive and one negative test before merging.

@sirosen sirosen marked this pull request as ready for review November 24, 2023 21:35
@sirosen sirosen merged commit a52d3c5 into python-jsonschema:main Nov 24, 2023
@nikolaik
Copy link
Copy Markdown
Contributor Author

Wow, thanks for finishing this! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants