metric: Fix precision format#159
Merged
hugovk merged 1 commit intopython-humanize:mainfrom Dec 9, 2023
Merged
Conversation
Member
|
Please can you share a snippet of code that reproduces the problem, and also include tests? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 9 9
Lines 746 746
=======================================
Hits 740 740
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I added a couple of tests. A snippet that shows the problem would be something like this: import humanize
print(humanize.metric(10, "", 0))
# expected: 10
# actual: ValueError: Format specifier missing precision |
Member
|
Thank you! |
|
I ran into the same problem (and found the same fix). It would be great to release a new version to PyPI that includes this fix. |
Member
|
Thanks for the ping, we're long overdue a release, I'll make one this week. |
Member
|
4.10.0 is released! |
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if I try to print a 2 digit number with precision 0, I get this error:
ValueError: Format specifier missing precisionbecause the format results in a negative precision number.This PR makes sure that the precision is at least 0