Improve detection of when to add additional points to root_locus#313
Merged
murrayrm merged 1 commit intopython-control:masterfrom Jun 17, 2019
Merged
Improve detection of when to add additional points to root_locus#313murrayrm merged 1 commit intopython-control:masterfrom
murrayrm merged 1 commit intopython-control:masterfrom
Conversation
1 similar comment
Member
Author
|
@icam0, @gonmolina, @repagh Small fix to |
Member
|
There were many formatting changes, so I couldn't easily find the functional change. Will add these as an example later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides improved checking of when to add points to a root locus plot and hence decreases the number of extraneous points that are generated. See issue #310 for details. The change is to detect when the root locus is on a line (typically the real axis) and to correct a calculation that was causing all points to be expanded (unnecessarily).
Also did some PEP8 and numpydoc cleanup while I was in the file.