Adaptive gain click criterion and zoom bug fix#302
Merged
murrayrm merged 9 commits intopython-control:masterfrom May 25, 2019
Merged
Adaptive gain click criterion and zoom bug fix#302murrayrm merged 9 commits intopython-control:masterfrom
murrayrm merged 9 commits intopython-control:masterfrom
Conversation
murrayrm
approved these changes
May 25, 2019
Member
murrayrm
left a comment
There was a problem hiding this comment.
Changes look good. There are some PEP8 warnings, but not urgent to fix now (and mainly unrelated).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed 2 bugs in the current sistool implementation with the help of @repagh :