address @slivingston review comments

murrayrm · murrayrm · commit 10f009b76ffb · 2024-07-06T19:20:13.000-07:00
diff --git a/control/ctrlplot.py b/control/ctrlplot.py
@@ -103,7 +103,7 @@ def _make_legend_labels(labels, ignore_common=False):
         common_prefix = common_prefix[:last_space]
     prefix_len = len(common_prefix)
 
-    # Look for a common suffice (up to a space)
+    # Look for a common suffix (up to a space)
     common_suffix = commonprefix(
         [label[::-1] for label in labels])[::-1]
     suffix_len = len(common_suffix)
diff --git a/control/nlsys.py b/control/nlsys.py
@@ -1317,7 +1317,7 @@ def nlsys(
 
 
 def input_output_response(
-        sysdata, T, U=0., X0=0, params=None, ignore_errors=False,
+        sys, T, U=0., X0=0, params=None, ignore_errors=False,
         transpose=False, return_x=False, squeeze=None,
         solve_ivp_kwargs=None, t_eval='T', **kwargs):
     """Compute the output response of a system to a given input.
@@ -1327,7 +1327,7 @@ def input_output_response(
 
     Parameters
     ----------
-    sysdata : I/O system or list of I/O systems
+    sys : NonlinearIOSystem or list of NonlinearIOSystem
         I/O system(s) for which input/output response is simulated.
 
     T : array-like
@@ -1449,16 +1449,14 @@ def input_output_response(
         raise TypeError("unrecognized keyword(s): ", str(kwargs))
 
     # If passed a list, recursively call individual responses with given T
-    if isinstance(sysdata, (list, tuple)):
-        responses = []
+    if isinstance(sys, (list, tuple)):
+        sysdata, responses = sys, []
         for sys in sysdata:
             responses.append(input_output_response(
                 sys, T, U=U, X0=X0, params=params, transpose=transpose,
                 return_x=return_x, squeeze=squeeze, t_eval=t_eval,
                 solve_ivp_kwargs=solve_ivp_kwargs, **kwargs))
         return TimeResponseList(responses)
-    else:
-        sys = sysdata
 
     # Sanity checking on the input
     if not isinstance(sys, NonlinearIOSystem):
diff --git a/doc/conventions.rst b/doc/conventions.rst
@@ -157,12 +157,12 @@ response from a non-zero initial condition.
 For linear time invariant (LTI) systems, the :func:`impulse_response`,
 :func:`initial_response`, and :func:`step_response` functions will
 automatically compute the time vector based on the poles and zeros of
-system.  If a list of systems is passed, a common time vector will be
+the system.  If a list of systems is passed, a common time vector will be
 computed and a list of responses will be returned in the form of a
-:class:`TimeResponseList` object.  The :func:`force_response` function can
+:class:`TimeResponseList` object.  The :func:`forced_response` function can
 also take a list of systems, to which a single common input is applied.
 The :class:`TimeResponseList` object has a `plot()` method that will plot
-each of the reponses in turn, using a sequence of different colors with
+each of the responses in turn, using a sequence of different colors with
 appropriate titles and legends.
 
 In addition the :func:`input_output_response` function, which handles
diff --git a/examples/plot_gallery.py b/examples/plot_gallery.py
@@ -6,7 +6,7 @@
 # used to compare what things look like between different versions of the
 # library.  It is mainly intended for uses by developers to make sure there
 # are no unexpected changes in plot formats, but also has some interest
-# examples of htings you can plot.
+# examples of things you can plot.
 
 import os
 import sys
@@ -21,9 +21,10 @@
 savefigs = 'PYCONTROL_TEST_EXAMPLES' not in os.environ
 if savefigs:
     # Create a pdf file for storing the results
+    import subprocess
     from matplotlib.backends.backend_pdf import PdfPages
     from datetime import date
-    git_info = os.popen('git describe').read().strip()
+    git_info = subprocess.check_output(['git', 'describe'], text=True).strip()
     pdf = PdfPages(
         f'plot_gallery-{git_info}-{date.today().isoformat()}.pdf')
 
