avoid setting Py_LIMITED_API when py_limited_api=False #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, setting py_limited_api=False only appeared to affect the ABI tag of modules, as Py_LIMITED_API was still unconditionally defined in most cases by _cffi_include.h
Contributor
|
The setting |
Contributor
Author
|
Makes perfect sense; done! |
Contributor
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, setting
py_limited_api=Falseonly appeared to affect the ABI tag of modules, as Py_LIMITED_API was still unconditionally defined in most cases by_cffi_include.hhere.The changlog says:
but this doesn't appear to have been the case. With this change, the behavior matches at least my understanding of the docs on the matter.
The fact that setting
py_limited_api=Falsedidn't work is what led me to #104, which is unnecessary with this PR.