Fix get_period_id() with dayPeriodRule across 0:00#871
Merged
akx merged 1 commit intopython-babel:masterfrom May 10, 2022
Merged
Fix get_period_id() with dayPeriodRule across 0:00#871akx merged 1 commit intopython-babel:masterfrom
dayPeriodRule across 0:00#871akx merged 1 commit intopython-babel:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
==========================================
- Coverage 91.34% 91.32% -0.02%
==========================================
Files 23 23
Lines 4192 4198 +6
==========================================
+ Hits 3829 3834 +5
- Misses 363 364 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
akx
approved these changes
May 10, 2022
Member
akx
left a comment
There was a problem hiding this comment.
Looks great, thank you! I would have added a comment noting that the first if statement takes care of rules that straddle days, but it's evident from the commit message. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #870.