Prevent wrapping file locations containing white space#1120
Merged
akx merged 6 commits intopython-babel:masterfrom Dec 10, 2024
Merged
Prevent wrapping file locations containing white space#1120akx merged 6 commits intopython-babel:masterfrom
akx merged 6 commits intopython-babel:masterfrom
Conversation
Member
Author
|
Interesting, calling super() inside a list comprehension does not work on python 3.9.. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
+ Coverage 91.27% 91.47% +0.20%
==========================================
Files 27 27
Lines 4619 4636 +17
==========================================
+ Hits 4216 4241 +25
+ Misses 403 395 -8 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Member
Author
akx
requested changes
Oct 19, 2024
Member
Author
|
Rebased and fixed the tests caused by missing |
akx
requested changes
Dec 9, 2024
Member
akx
left a comment
There was a problem hiding this comment.
Small comment about the readability of the new splitter, now that I look at it again... 😅
Co-authored-by: Aarni Koskela <akx@iki.fi>
tomasr8
commented
Dec 9, 2024
Member
Author
|
Alright, should be good now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1078
Depends on #1105 (To see only the changes in this PR, look at the last two commits)Since #1105 wraps file names containing white space in special unicode markers, we look out for them when
wrapping comments.
The fix overrides the
_splitmethod ofTextWrapperwhere we manually generate the indivisible chunks, taking intoaccount enclosed file names.
I test the the wrapping behavior with gettext 0.22.5 (which includes the enclosing logic) to make sure it's consistent