Conversation
Need some working tests before attempting to fix python-babel#990. Refs python-babel#990
In certain OS installations, the target of /etc/localtime contains double slashes. This is a valid path, but not a valid zoneinfo key. This fix replaces `os.readlink` with `os.path.realpath`, which is guaranteed to return a normalized path. Fixes python-babel#990
akx
left a comment
There was a problem hiding this comment.
Would it be possible to formulate the tests without adding the new pyfakefs dependency?
The Unix tests are the only ones that use |
That sounds a bit heavy-handed too... What if you just |
It turns out that
The It looks like it would only be necessary to mock |
This is an update of #1006 that incorporates upstream fixes to previously-broken tests. It should pass all CI checks now.
This PR:
localtimemodule (developed on macOS, test stub added for Windows)