Depend on setuptools since Python 3.12#1033
Merged
akx merged 1 commit intopython-babel:masterfrom Oct 23, 2023
Merged
Conversation
The dependency was already added specifically for CI, but that is not correct, because it's the package itself that actually depends on setuptools
vstinner
approved these changes
Oct 7, 2023
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
You might explain in a comment that the intent of installing setuptools is to get distutils ;-)
akx
approved these changes
Oct 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 25 25
Lines 4393 4393
=======================================
Hits 3997 3997
Misses 396 396 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency was already added specifically for CI, but that is not correct, because it's the package itself that actually depends on setuptools