Skip to content

Added missing imports to hook factory decorator example.#677

Merged
Tinche merged 2 commits intopython-attrs:mainfrom
carltongibson:patch-2
Aug 4, 2025
Merged

Added missing imports to hook factory decorator example.#677
Tinche merged 2 commits intopython-attrs:mainfrom
carltongibson:patch-2

Conversation

@carltongibson
Copy link
Contributor

Hey @Tinche 👋

I was just reviewing the docs, and noticed the get_args import missing, which I think it adds to have. I put the example in the editor and it complained about Any and Callable too (which I guess is fair). I thought I'd send in the clean up.

@Tinche
Copy link
Member

Tinche commented Aug 4, 2025

Nice, thanks! Let's be modern and import Callable from collections.abc though ;)

@carltongibson
Copy link
Contributor Author

Let's be modern...

You kids 😉

@Tinche
Copy link
Member

Tinche commented Aug 4, 2025

Gracias!

@Tinche Tinche merged commit 7943a6a into python-attrs:main Aug 4, 2025
12 checks passed
@carltongibson carltongibson deleted the patch-2 branch August 4, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants