Skip to content

Make ForbiddenExtraKeysError.__str__ deterministic#670

Merged
Tinche merged 1 commit intopython-attrs:mainfrom
AlexWaygood:flaky-test
Jul 6, 2025
Merged

Make ForbiddenExtraKeysError.__str__ deterministic#670
Tinche merged 1 commit intopython-attrs:mainfrom
AlexWaygood:flaky-test

Conversation

@AlexWaygood
Copy link
Contributor

Fixes #669. Currently the value returned by this method can differ depending on the iteration order of a set, which isn't deterministic. This causing test_errors_pickling to be flaky.

@Tinche
Copy link
Member

Tinche commented Jul 6, 2025

Thanks!

@Tinche Tinche merged commit 591b4f7 into python-attrs:main Jul 6, 2025
11 checks passed
@Tinche Tinche added this to the 25.2 milestone Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_errors_pickling is flaky

2 participants