(errors) Correctly set BaseException.args and make them pickable#666
Merged
Tinche merged 3 commits intopython-attrs:mainfrom Jul 2, 2025
Merged
(errors) Correctly set BaseException.args and make them pickable#666Tinche merged 3 commits intopython-attrs:mainfrom
BaseException.args and make them pickable#666Tinche merged 3 commits intopython-attrs:mainfrom
Conversation
919b0d1 to
50a9a99
Compare
Member
|
Great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseExceptionssubclasses need all parameters of their__init__methods to be passed toBaseExceptions.__init__, seeBaseException.argsfor that.This MR will correct the
super().__init__call.This will also make the Exceptions pickable, which I need for a cache and for multiprocessing.
The interface does not change with this MR.
But for
ForbiddenExtraKeysErrorI moved thestring to
__str__instead of storing it in the object as attribute. As this is a fixed string for the class (which means it does not need be stored) and will be used when actually""was passed to the constructor, I think this makes more sense.