Allows use of typing_extensions.Annotated when python version is less than 3.9#366
Conversation
|
Cool! Can you add a changelog entry too? And maybe a line to the Annotated sections in the docs? |
@Tinche, I just added an entry under the current unreleased version. Let me know if any other changes are needed. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #366 +/- ##
===========================================
- Coverage 95.88% 84.71% -11.18%
===========================================
Files 26 26
Lines 2139 2139
===========================================
- Hits 2051 1812 -239
- Misses 88 327 +239
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Tinche
left a comment
There was a problem hiding this comment.
Please rebase and let's get this merged in.
|
@Tinche, not sure why CI isn't running but this looks good to go. |
|
I reran the action, looks like there's a linting issue now. |
|
@Tinche, can you run CI again? |
…r get_origin" This reverts commit 9a5aa3e.
|
Looks like everything passes except |
|
Sweet. I don't actually know where the pre-commit.ci is defined. Maybe the python-attrs organization? |
Currently, the use of
typing_extensions.Annotateddoesn't work. This PR adds support for the type when the version of Python is less that3.9(i.e., the user can't usetyping.Annotated).