Add optional dependencies for preconf libraries#337
Merged
Tinche merged 5 commits intopython-attrs:mainfrom Mar 21, 2023
alexomics:main
Merged
Add optional dependencies for preconf libraries#337Tinche merged 5 commits intopython-attrs:mainfrom alexomics:main
Tinche merged 5 commits intopython-attrs:mainfrom
alexomics:main
Conversation
This commit adds optional dependencies for the preconf factories, allowing easier install for downstream users. E.G.: ```console pip install cattrs[tomlkit] ```
Member
|
Very cool, I'm in favor. Although I think the Let's add a change log entry for sure, and to the preconf docs page. |
Contributor
Author
|
Thanks for the quick reply! I've added some explanation to the preconf docs and a changelog entry. Let me know if you think it needs more detail |
Member
|
Looks like we have test failures, let's get that fixed and merge this in! Good job! |
Member
|
Sweet, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds optional dependencies for the preconf libraries, allowing easier install for downstream users. E.G.:
pip install cattrs[tomlkit]and (I hope) pyproject.toml:
It's a small change that moves the preconf dependencies out of the dev group and marks them as optional/extra. It adds an optional dependency on each library and a
preconfoption that installs all extras.The change to the tox.ini is needed as I couldn't work out how, with poetry, to add the preconf dependencies back in so that they weren't duplicated.
I'm sure that I will need to update some docs for this, but I'm not sure where would be best!