Fix inconsistent tuple/typing.Tuple unstructuring#227
Merged
Tinche merged 4 commits intopython-attrs:mainfrom Mar 20, 2022
bibajz:bibajz/tuple_unstructuring
Merged
Fix inconsistent tuple/typing.Tuple unstructuring#227Tinche merged 4 commits intopython-attrs:mainfrom bibajz:bibajz/tuple_unstructuring
tuple/typing.Tuple unstructuring#227Tinche merged 4 commits intopython-attrs:mainfrom
bibajz:bibajz/tuple_unstructuring
Conversation
tuple/typing,Tuple unstructuring
tuple/typing,Tuple unstructuringtuple/typing.Tuple unstructuring
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 16 16
Lines 779 779
=======================================
Hits 763 763
Misses 16 16
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
Author
|
Hi @Tinche, is this ok? Or would you add something? |
Member
|
Looks ok, will take another look and maybe merge later. 👍 |
Contributor
Author
Got it, thanks! |
Member
|
Merged, thanks! |
Contributor
Author
|
Hi @Tinche , thanks for merge! Are there some other issues I could help you with? Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226
Fixes #214
Now, all tuples are unstructured to
listby default.Needs a changelog entry andwe are ready to go!