Support to respect default values from attr class#15
Merged
Tinche merged 3 commits intopython-attrs:masterfrom Nov 9, 2017
Merged
Support to respect default values from attr class#15Tinche merged 3 commits intopython-attrs:masterfrom
Tinche merged 3 commits intopython-attrs:masterfrom
Conversation
added 2 commits
October 27, 2017 19:32
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 99.03% 99.05% +0.01%
==========================================
Files 18 18
Lines 935 948 +13
==========================================
+ Hits 926 939 +13
Misses 9 9
Continue to review full report at Codecov.
|
…ed on primitive types
Member
|
Hi, I'm sick ATM so it might be a few days until I get around to this. Thanks :) |
Member
|
Hello, thanks for this. I'll take it in and maybe refactor it a little. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are to fix #10 or #14
I added one unit test to support creating the attr class without providing optional value.
@Tinche let me know your feedback on the same.