Skip to content

Conversation

@Tyrubias
Copy link
Contributor

@Tyrubias Tyrubias commented Sep 21, 2023

Summary

Detect if __attrs_pre_init__ has arguments besides self using inspect.signature. If so, pass __attrs_pre_init__ the same arguments that __init__ (or __attrs_init__) expects. This closes #1102.

This is my first contribution to this project, so I would greatly appreciate any feedback.

Pull Request Check List

  • Added tests for changed code.
    Our CI fails if coverage is not 100%.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
    • If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      The next version is the second number in the current release + 1.
      The first number represents the current year.
      So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
      If the next version is the first in the new year, it'll be 23.1.0.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

Detect if `__attrs_pre_init__` has arguments besides `self`
using `inspect.signature`. If so, pass `__attrs_pre_init__`
the same arguments that `__init__` (or `__attrs_init__`)
expects.
@Tinche Tinche self-requested a review September 26, 2023 14:40
@hynek hynek merged commit c2824ac into python-attrs:main Sep 29, 2023
@hynek
Copy link
Member

hynek commented Sep 29, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass all args to __attrs_pre_init__()

3 participants