Fix TypeError for asdict(<class with namedtuple>, retain_collection_types=True)
#1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdict(<class with namedtuple>, retain_collection_types=True)
asdict(<class with namedtuple>, retain_collection_types=True)asdict(<class with namedtuple>, retain_collection_types=True) (#1164)
asdict(<class with namedtuple>, retain_collection_types=True) (#1164)asdict(<class with namedtuple>, retain_collection_types=True)
hynek
reviewed
Jul 22, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
hynek
reviewed
Jul 28, 2023
Member
hynek
left a comment
There was a problem hiding this comment.
Thanks!
I've fixed some stylistic issues, let's see what the CI has to say.
Comment on lines
456
to
457
| instance = A(Coordinates(50.419019, 30.516225)) | ||
| assert (Coordinates(50.419019, 30.516225),) == attr.astuple( |
Member
There was a problem hiding this comment.
Suggested change
| instance = A(Coordinates(50.419019, 30.516225)) | |
| assert (Coordinates(50.419019, 30.516225),) == attr.astuple( | |
| instance = A(Coordinates(50.419019, 30.516225)) | |
| assert (Coordinates(50.419019, 30.516225),) == attr.astuple( |
Contributor
Author
|
Sure 👍 |
hynek
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pull Request Check List
Our CI fails if coverage is not 100%.
.pyi).tests/typing_example.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives.The next version is the second number in the current release + 1.
The first number represents the current year.
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
If the next version is the first in the new year, it'll be 23.1.0.
.rstfiles is written using semantic newlines.changelog.d.Resolves #1164