avoid a hot splitlines

Tinche · Tinche · commit 532faed49c69 · 2025-02-10T22:22:20.000+01:00
diff --git a/src/attr/_make.py b/src/attr/_make.py
@@ -223,7 +223,7 @@ def _compile_and_eval(
     eval(bytecode, globs, locs)
 
 
-def _make_method(script, filename, globs, locals=None) -> dict:
+def _make_method(script, scriptlines, filename, globs, locals=None) -> dict:
     """
     Create the method with the script given and return the method object.
     """
@@ -237,7 +237,7 @@ def _make_method(script, filename, globs, locals=None) -> dict:
         linecache_tuple = (
             len(script),
             None,
-            script.splitlines(True),
+            scriptlines,
             filename,
         )
         old_val = linecache.cache.setdefault(filename, linecache_tuple)
@@ -534,6 +534,7 @@ def _make_cached_property_getattr(cached_properties, original_getattr, cls):
 
     return _make_method(
         "\n".join(lines),
+        lines,
         unique_filename,
         glob,
         locals={
@@ -769,13 +770,15 @@ def __repr__(self):
 
     def _eval_snippets(self) -> None:
         """Evaluate any registered snippets in one go."""
-        script = "\n".join([snippet[0] for snippet in self._script_snippets])
+        script_lines = [snippet[0] for snippet in self._script_snippets]
+        script = "\n".join(script_lines)
         globs = {}
         for _, snippet_globs, _ in self._script_snippets:
             globs.update(snippet_globs)
 
         locs = _make_method(
             script,
+            script_lines,
             filename=_generate_unique_filename(self._cls, "methods"),
             globs=globs,
         )
